apache / shiro

Apache Shiro
https://shiro.apache.org/
Apache License 2.0
4.3k stars 2.31k forks source link

[Enhancement] Improve Shiro's Spring Support #1576

Open bdemers opened 2 months ago

bdemers commented 2 months ago

Search before asking

Enhancement Request

I think, it would be better for Shiro's Spring support to integrate with Spring Security (e.g. Spring Sec, delegate to Shiro), instead of as a replacementĀ  This would reduce a lot of code, footprint, and complexity of the integration.

Describe the solution you'd like

Create a Spring Security AuthenticationProvider that delegates to Shiro.

I've hacked on this a couple of times but I ran into a few minor issues each time, and then ran out of time to continue.

I'd love to hear other thoughts on this

Are you willing to submit PR?

lprimak commented 2 months ago

I think this is a great idea!

lprimak commented 2 months ago

Supersedes #1236

lprimak commented 2 months ago

Does this mean that Shiro/Spring can finally be configured via shiro.ini as well?

bdemers commented 2 months ago

I hadn't thought about that šŸ¤” Possibly...