search

apache / singa

a distributed deep learning platform
Apache License 2.0
3.35k stars 1.24k forks source link

Fix some GitHub Actions #1153

Closed tinyAdapter closed 5 months ago

tinyAdapter commented 6 months ago

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.74%. Comparing base (05876f9) to head (bf5f6ed). Report is 219 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1153 +/- ## ======================================= Coverage 60.74% 60.74% ======================================= Files 85 85 Lines 4524 4524 ======================================= Hits 2748 2748 Misses 1776 1776 ``` | [Flag](https://app.codecov.io/gh/apache/singa/pull/1153/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [singa-cpp](https://app.codecov.io/gh/apache/singa/pull/1153/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.74% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lzjpaul commented 6 months ago

Hello tinyAdapter,

Thanks for your pull request!

Could you please send the pull request to dev-postgresql branch?

Also, could we keep in contact on these issues? You can send me an email via zhaojing@apache.org

Thanks, Zhaojing.

lzjpaul commented 6 months ago

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Hello tinyAdapter,

Thanks for your pull request!

Could you please send the pull request to dev-postgresql branch?

Also, could we keep in contact on these issues? You can send me an email via zhaojing@apache.org

Thanks, Zhaojing.

tinyAdapter commented 5 months ago

Seems the updated action has been reflected in the latest dev-postgresql branch. Closed.