search

apache / skywalking

APM, Application Performance Monitoring System
https://skywalking.apache.org/
Apache License 2.0
23.77k stars 6.51k forks source link

[Feature] xxl-job plugin upgrade #10624

Closed leon756 closed 1 year ago

leon756 commented 1 year ago

Search before asking

Description

In skywalking v8.7.0, the xxl-job plugin version is 2.2.0. And xxl-job 2.3.0 is not applicable.

Use case

The *JobHandlerMethodInterceptor are not effective.

Related issues

https://github.com/apache/skywalking/issues/9470

Are you willing to submit a PR?

Code of Conduct

leon756 commented 1 year ago

https://github.com/apache/skywalking/commit/5ba96666dc39e4f2faa9e22610d51b2089507dd3

wu-sheng commented 1 year ago

If you want to submit a pull request to expand the supported list, go ahead. You don't have to build an issue to track. And what you posted is a little strange about based on 8.7.0. We only could accept a pull request from the latest codebase.

leon756 commented 1 year ago

@wu-sheng I am not familiar with the latest one, and did not find where the xxl-job plugin placed.

wu-sheng commented 1 year ago

It is here, https://github.com/apache/skywalking-java/tree/main/apm-sniffer/apm-sdk-plugin/xxl-job-2.x-plugin, in a separate repository.

leon756 commented 1 year ago

Thank you. I found that the plugin has been updated in skywalking-java already.