apache / skywalking

APM, Application Performance Monitoring System
https://skywalking.apache.org/
Apache License 2.0
23.92k stars 6.53k forks source link

[Bug] The 'findEndpoint' method 'limit' condition does not work when using Elasticsearch storage #11487

Closed ding-9 closed 1 year ago

ding-9 commented 1 year ago

Search before asking

Apache SkyWalking Component

OAP server (apache/skywalking)

What happened

The 'Endpoint' page returns more than 20 pieces of data, with the storage policy configured as elasticsearch.

MetadataQueryEsDAO.java#L278

The 'scroll' query way actually returns all the hit data.

What you expected to happen

The 'limit' condition can work.

How to reproduce

make a 'findEndpoint' query and specify a smaller 'limit'.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

Code of Conduct

wu-sheng commented 1 year ago

@kezhenxu94 I saw you created a fix branch. Is that verified?

kezhenxu94 commented 1 year ago

@kezhenxu94 I saw you created a fix branch. Is that verified?

I nearly forgot the branch I created, just opened a pull request here https://github.com/apache/skywalking/pull/11523