[Bug] skywalking-showcase docker deployment has some incorrect parts

yswdqz commented 7 months ago

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Showcase (apache/skywalking-showcase)

What happened

rocketmq-feature seems incorrect:

I believe that a feature should utilize a common OAP(such as single-node) instead of spinning up a new one. Additionally, there are issues with the configuration of this OAP.
whether we need to expose this port?
oap dependency

Some feature depend on oap. However, in some cases, we only need these services and do not require the built-in OAP.

and also, some config files use oap as host:

so we can't easily edit Makefile to change oap address.

Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

wu-sheng commented 7 months ago

@kezhenxu94 Could you guide @yswdqz about this? We may need to polish showcase.

kezhenxu94 commented 7 months ago

rocketmq-feature seems incorrect:

I believe that a feature should utilize a common OAP(such as single-node) instead of spinning up a new one. Additionally, there are issues with the configuration of this OAP.

Nice catch! I think we can fix this by simply removing the OAP section in this docker compose file.

whether we need to expose this port?

This is not mandatory as we have a loadgen to trigger traffic, however, if users want to manually trigger traffic, they can open this port in their browser.

oap dependency

Some feature depend on oap. However, in some cases, we only need these services and do not require the built-in OAP.

Can you elaborate? OAP is required to be up and running for those components that need to talk to OAP, in your screenshot, the vm exporter needs to send data to OAP so it needs to wait for OAP's readiness.

and also, some config files use oap as host: so we can't easily edit Makefile to change oap address.

Good catch, this can be replace with the env var BACKEND_SERVICE.

Will you file a pull request @yswdqz ?

yswdqz commented 7 months ago

Yes, but I might not have much time recently. I'll submit the PR over the weekend.

yswdqz commented 7 months ago

Can you elaborate? OAP is required to be up and running for those components that need to talk to OAP, in your screenshot, the vm exporter needs to send data to OAP so it needs to wait for OAP's readiness

Maybe we just need VM-monitor feature, and I just want run with "make deploy.docker FEATURE_FLAGS=vm"(not FEATURE_FLAGS=vm,single-node)

kezhenxu94 commented 7 months ago

Can you elaborate? OAP is required to be up and running for those components that need to talk to OAP, in your screenshot, the vm exporter needs to send data to OAP so it needs to wait for OAP's readiness

Maybe we just need VM-monitor feature, and I just want run with "make deploy.docker FEATURE_FLAGS=vm"(not FEATURE_FLAGS=vm,single-node)

This doesn't make sense as this is a "skywalking" showcase, we don't bother to make it work without skywalking

yswdqz commented 7 months ago

This doesn't make sense as this is a "skywalking" showcase, we don't bother to make it work without skywalking

Sorry, my expression was not very clear. My meaning is, some people (including myself) may want to import data into an external OAP, rather than using a single-node.

wu-sheng commented 7 months ago

This doesn't make sense as this is a "skywalking" showcase, we don't bother to make it work without skywalking

Sorry, my expression was not very clear.

My meaning is, some people (including myself) may want to import data into an external OAP, rather than using a single-node.

That is not showcase. We don't need to consider that.

apache / skywalking