apache / skywalking

APM, Application Performance Monitoring System
https://skywalking.apache.org/
Apache License 2.0
23.72k stars 6.5k forks source link

[BanyanDB] Optimizing Column Encoding #12445

Open hanahmily opened 2 months ago

hanahmily commented 2 months ago

Search before asking

Description

There are several optimizations we should apply to the column encoding, the column refers to tags and fields.

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

Code of Conduct

sollhui commented 2 months ago

Please assign to me.

wu-sheng commented 2 months ago

Are you confident to take two in the same time? How much do you understand BanyanDB?

sollhui commented 2 months ago

Are you confident to take two in the same time? How much do you understand BanyanDB?

I am familiar with BanyanDB code and have contributed 10 PR, but I don't think it's an easy task. Let me discuss it with @hanahmily first

wu-sheng commented 2 months ago

This is on the next iteration only, unless you will finish it in time for 0.7. So, don't hurry and take your time.

@hanahmily Please note, as we are changing docs to user oriented, please make sure the file structure docs covers encoding docs with proper docs and clear examples.

hanahmily commented 2 months ago

@sollhui Let's discuss the details first.

@wu-sheng Sure, we will update the relevant documents according to the new structures. This change will not break the file system; therefore, we do not have to increase the file system version.

wu-sheng commented 2 months ago

Let's discuss details when you have the design. I am not sure how to change the encoding doesn't affect storage structure. Changing doesn't mean breaking, such as, you have a new encoding type, which will also affect new structure in the file, but no breaking.