[Feature] A better approach to integrate AsyncProfiler parser - Githubissues

apache / skywalking

APM, Application Performance Monitoring System

https://skywalking.apache.org/

Apache License 2.0

23.92k stars 6.53k forks source link

[Feature] A better approach to integrate AsyncProfiler parser #12736

Closed lujiajing1126 closed 1 week ago

lujiajing1126 commented 3 weeks ago

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description

Currently in the https://github.com/apache/skywalking/pull/12671, many classes are copied from the official AsyncProfiler repo in order to parse JFR.

But the copied files and their Licenses (headers) are not easy to be maintained.

A solution https://github.com/jvm-profiling-tools/ap-loader, which is mentioned by the author of AsyncProfiler may be considered.

Use case

No response

Related issues

https://github.com/apache/skywalking/pull/12671#discussion_r1823722484

Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

wu-sheng commented 3 weeks ago

fyi @zhengziyi0117 as owner.