apache / skywalking

APM, Application Performance Monitoring System
https://skywalking.apache.org/
Apache License 2.0
23.89k stars 6.52k forks source link

[Feature] Replace context structs for tracepoint/syscall programs #12776

Open tsint opened 3 hours ago

tsint commented 3 hours ago

Search before asking

Description

Referencing this issue comment, to avoid the impact of buggy kernels, it is recommended to use struct syscall_trace_exit to prevent issues where incorrect offset calculations lead to the verifier rejecting the BPF progs loading.

Use case

replace struct trace_point_common_exit with struct syscall_trace_exit

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

Code of Conduct

wu-sheng commented 3 hours ago

@mrproliu Here is another proposal.

mrproliu commented 2 hours ago

Yes, we can do this. Please go ahead on this, thanks.