'spanLayer' is null in optional plugin(gateway-2.0.x-plugin gateway-2.1.x-plugin) for springcloud gateway?

apache / skywalking

APM, Application Performance Monitoring System

https://skywalking.apache.org/

Apache License 2.0

23.82k stars 6.52k forks source link

'spanLayer' is null in optional plugin(gateway-2.0.x-plugin gateway-2.1.x-plugin) for springcloud gateway? #6331

Closed panghuchi closed 3 years ago

panghuchi commented 3 years ago

Please answer these questions before submitting your issue.

Why do you submit this issue?
[X] Question or discussion

Question

What do you want to know? 'spanLayer' is null in optional plugin(gateway-2.0.x-plugin gateway-2.1.x-plugin) for springcloud gateway.

wu-sheng commented 3 years ago

You are welcome to fix this through pull request.

panghuchi commented 3 years ago

Also, Why NettyRoutingFilterInterceptor In Spring Cloud Gateway Plugin using LocalSpan, and setting "SpringCloudGateway/RoutingFilter" as default operation name? Would it be better to use EntrySpan and set different request path as operation name?

wu-sheng commented 3 years ago

Because the webflux plugin takes the responsibility of creating entry span. Routing is only for propagating the context.

wu-sheng commented 3 years ago

Read this expected data file in the test, https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/gateway-2.0.x-scenario/config/expectedData.yaml#L46