apache / skywalking

APM, Application Performance Monitoring System
https://skywalking.apache.org/
Apache License 2.0
23.86k stars 6.52k forks source link

[Bug] [PHP] 8.2 support #9755

Closed remicollet closed 2 years ago

remicollet commented 2 years ago

Search before asking

Apache SkyWalking Component

CLI (apache/skywalking-cli)

What happened

error[E0425]: cannot find value `name_length` in this scope
   --> /dev/shm/BUILD/php82-php-pecl-skywalking-agent-0.1.0/mycargo/phper/src/ini.rs:255:9
    |
255 |         name_length,
    |         ^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `_zend_get_parameters_array_ex` in this scope
     --> /dev/shm/BUILD/php82-php-pecl-skywalking-agent-0.1.0/mycargo/phper/src/values.rs:135:13
      |
135   |               _zend_get_parameters_array_ex(num_args.try_into().unwrap(), arguments.as_mut_ptr());
      |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `zend_get_parameters_array_ex`
      |
     ::: /dev/shm/BUILD/php82-php-pecl-skywalking-agent-0.1.0/NTS/target/release/build/phper-sys-ddd865524bd4c63b/out/php_bindings.rs:35951:5
      |
35951 | /     pub fn zend_get_parameters_array_ex(param_count: u32, argument_array: *mut zval)
35952 | |         -> zend_result;
      | |______________________- similarly named function `zend_get_parameters_array_ex` defined here

What you expected to happen

PHP 8.2 support

How to reproduce

Build using PHP 8.2

Anything else

No response

Are you willing to submit PR?

Code of Conduct

jmjoy commented 2 years ago

This should be supported in phper, but, the PHP 8.2 haven't released stable now.

remicollet commented 2 years ago

So https://github.com/phper-framework/phper/issues/58