search

apache / skywalking

APM, Application Performance Monitoring System
https://skywalking.apache.org/
Apache License 2.0
23.72k stars 6.5k forks source link

[Bug] [PHP] offline build #9758

Closed remicollet closed 1 year ago

remicollet commented 1 year ago

Search before asking

Apache SkyWalking Component

CLI (apache/skywalking-cli)

What happened

Unable to build offline as the dependencies are download on the fly

What you expected to happen

Able to buid offline

How to reproduce

pecl install skywalking_agent-0.1.0.tgz

Anything else

A possible workaround (used for success for other extension skywalking)

run "cargo vendor xxx" and add this folder (its archive) in the package

Are you willing to submit PR?

Code of Conduct

wu-sheng commented 1 year ago

This may be a little tricky as we are placed in the ASF. In the source tar, we should not release dependencies source codes unless have to do.

wu-sheng commented 1 year ago

@remicollet Could you share why you expect offline build? Is there any specific case requiring this?

remicollet commented 1 year ago

this is a common practice (even mandatory for official repository) to build packages (RPM or other formats) offline also required for reproducible builds.

wu-sheng commented 1 year ago

I will leave this to @heyanlong @jmjoy to decide. After all, at the ASF, we either provide ASF-owned source codes or a compiled binary for convenience. All repositories of SkyWalking, even the whole ASF, follow this practice. It seems we face conflicts cross-orgs.

remicollet commented 1 year ago

BTW, a workaround exists and can be used on the packager side. And as (from other issues/discussions) is seems this PHP extension is not suitable for Enterprise distribution So probably don't worth the work to try to build RPM of it.

jmjoy commented 1 year ago

I think you can run cargo vendor and repackage by yourself, instead of using the official PECL package.