[Bug] dubbo 3.1.0 skywalking 8.9.1 agent 8.12.0 tid no transmit

JavaLionLi commented 1 year ago

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Java Agent (apache/skywalking-java)

What happened

dubbo 3.1.0 skywalking 8.9.1 agent 8.12.0 tid no transmit

A service B service

What you expected to happen

Context transfer tid

How to reproduce

dubbo 3.1.0 skywalking 8.9.1 agent 8.12.0

Anything else

No response

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

wu-sheng commented 1 year ago

Ask Dubbo community, maybe they change thread models.

JavaLionLi commented 1 year ago

Ask Dubbo community, maybe they change thread models.

dubbo貌似把这个方法淘汰了 3.1.X中应该不能这么用

wu-sheng commented 1 year ago

https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/dubbo-3.x-scenario

Dubbo 3 case exists, you could check. And toolkit has logic relationship with Dubbo. You have yo make sure the codes run in the same thread of Dubbo instrumented claases(filters)

What you post, I can not tell it is relative or not. You seem only pushing all things to us, this is not how we work.

JavaLionLi commented 1 year ago

https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/dubbo-3.x-scenario

Dubbo 3 case exists, you could check. And toolkit has logic relationship with Dubbo. You have yo make sure the codes run in the same thread of Dubbo instrumented claases(filters)

What you post, I can not tell it is relative or not. You seem only pushing all things to us, this is not how we work.

No asynchronous, all synchronous

wu-sheng commented 1 year ago

If you just try to read source codes a little, you would know, NA means you even don't install agent. Or agent kernel is not working.

https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/LogbackPatternConverter.java#L34

JavaLionLi commented 1 year ago

If you just try to read source codes a little, you would know, NA means you even don't install agent. Or agent kernel is not working.

https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/LogbackPatternConverter.java#L34

......... If the agent is not installed, where does the above log come from

JavaLionLi commented 1 year ago

If you just try to read source codes a little, you would know, NA means you even don't install agent. Or agent kernel is not working.

https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/LogbackPatternConverter.java#L34

It has been explained at the top that the logback plug-in has been imported If you keep avoiding problems, then I don't want to say

JavaLionLi commented 1 year ago

If you just try to read source codes a little, you would know, NA means you even don't install agent. Or agent kernel is not working. https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/LogbackPatternConverter.java#L34

......... If the agent is not installed, where does the above log come from

As mentioned above, service A has tid, service B does not, and they all import the same dependency

wu-sheng commented 1 year ago

Only the toolkit without agent could output "TID: N/A";, as the codes show.

If you keep avoiding problems, then I don't want to say

I don't know what you mean. From an open-source perspective, we don't have any obligation to support. That is what Apache 2.0 license says. We don't owe you anything.

JavaLionLi commented 1 year ago

Only the toolkit without agent could output "TID: N/A";, as the codes show.

If you keep avoiding problems, then I don't want to say

I don't know what you mean. From an open-source perspective, we don't have any obligation to support. That is what Apache 2.0 license says. We don't owe you anything.

I think the tid of service A is not transferred to service B, which is just a problem.

Similarly, B service calls A service, B has tid, A does not

Can we prove that both A and B have agents

I didn't say how you were. I just gave feedback. If you think it's OK, then it's OK

wu-sheng commented 1 year ago

I don't think there is the case. Even the trace context(including your trace ID) is not propagated into service B, you would still have trace ID, just a new one.

I had provided you with a very clear thing. There is no more I can say.

Can we prove that both A and B have agents

https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/LogbackPatternConverter.java#L34 is for proving only no-agent not installed.

JavaLionLi commented 1 year ago

I don't think there is the case. Even the trace context(including your trace ID) is not propagated into service B, you would still have trace ID, just a new one.

I had provided you with a very clear thing. There is no more I can say.

Can we prove that both A and B have agents

https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-logback-1.x/src/main/java/org/apache/skywalking/apm/toolkit/log/logback/v1/x/LogbackPatternConverter.java#L34 is for proving only no-agent not installed.

Another point is not clear. There is no problem with the link on the UI. Only 'logback' cannot be output I will continue to investigate

apache / skywalking