search

apache / solr-operator

Official Kubernetes operator for Apache Solr
https://solr.apache.org/operator
Apache License 2.0
246 stars 111 forks source link

Fix non-recurring backups #509

Closed HoustonPutman closed 1 year ago

HoustonPutman commented 1 year ago

https://github.com/apache/solr-operator/pull/455 introduced a bug for non-recurring backups that was unearthed while working on https://github.com/apache/solr-operator/pull/507

Basically we need to only update the NextScheduledTimestamp if recurrence is enabled.

I also restructured the logic to hopefully make it more clear when backup logic should be run.

HoustonPutman commented 1 year ago

maybe next time we could put some of the more cosmetic improvements in their own commit, but it seems pretty harmless here.

Good call, just included since I was going mad trying to fix it so many ways before realizing that I wasn't testing the changes at all....