search

apache / solr-operator

Official Kubernetes operator for Apache Solr
https://solr.apache.org/operator
Apache License 2.0
243 stars 112 forks source link

Observed generation field addition in solr-operator code #579

Open Dhru205 opened 1 year ago

Dhru205 commented 1 year ago

Hi, I am running solr operator 0.6.0 and solr version 9.1.0 in kubernetes environment and I want to configure the below changes: I want to add a status field called observed generation in solr-operator code, this field will help me to check how many times changes were made in solr were successful. Whenever we are describing the CustomResource deployed for a Solr cluster we should be able to display current status of cluster deployment such as Pending, Running or Failed. I want to see this is under status section while describing CustomResource. Also I want observed generation field to be increase with every successful solr deployment. So let me know where exactly I need to add this feature in solr operator code.

HoustonPutman commented 1 year ago

Whenever we are describing the CustomResource deployed for a Solr cluster we should be able to display current status of cluster deployment such as Pending, Running or Failed. I want to see this is under status section while describing CustomResource.

Do the Replicas, Ready Replicas and Up to date Replicas values not provide this information already? It's hard for the solr operator to determine whether a non-ready cloud is "pending" or "failed", so this is would be difficult to implement.

Also I want observed generation field to be increase with every successful solr deployment. So let me know where exactly I need to add this feature in solr operator code.

increase with every successful solr deployment needs to be more clear here. It could mean any update to the StatefulSet, or it could mean any update to the SolrCloud resource. Also what value does this provide?

The statefulSet.Status has an observedGeneration field, is this what you are looking for?

Dhru205 commented 1 year ago

Hi @HoustonPutman I am attaching screenshots of one DB which has already in built feature of observed generation so that you can get the clarity of what exactly is the feature that I want to add in Solr.

MicrosoftTeams-image (3)

As you can see in the above screenshot I checked the CR of Cassandra.

operator

MicrosoftTeams-image (4)

The operator is in ready state and observed generation value is 1 since no changes are made in the configurations.

MicrosoftTeams-image (5) MicrosoftTeams-image (6)

I changed the CPU and resources of Cassandra and only after all the pods are up and running then only observed Gen value is changed from 1 to 2.

HoustonPutman commented 11 months ago

Yeah, given #560 , we will have a pretty good idea as to when operations start/end. This could certainly be implemented. It looks like it's following a similar paradigm to pod status conditions. Not sure when it will get in, but this is certainly possible to do, and will be easier when the linked issue is resolved.

Dhru205 commented 11 months ago

Hi @HoustonPutman, When can we see this feature added in solr or is it still in the testing phase?

HoustonPutman commented 10 months ago

Not sure what you mean by "this feature", but if you mean the locked cluster operations, its a feature of the solr operator and has been merged in for the next release (v0.8.0).

rashiga commented 9 months ago

Hi , I could understand that we are showing status per solr Node. Is there any way by which we can show an aggregated status through Observed Generation which tells us that the change in the spec that we have done is applied to the solr pods and they are running successfully?