apache / solr-operator

Official Kubernetes operator for Apache Solr
https://solr.apache.org/operator
Apache License 2.0
243 stars 112 forks source link

fix: avoid reset of security.json if get fails (#659) #660

Closed smoldenhauer-ish closed 3 months ago

smoldenhauer-ish commented 7 months ago

adapted the expected setup-zk command and tested locally make prepare check and the end tests make e2e-tests SOLR_IMAGE=solr:8.11

HoustonPutman commented 3 months ago

@smoldenhauer-ish your PR is from an organizational fork, so I'm unable to push a changelog entry, but can you merge main into your branch, then add the following changelog entry to helm/solr-operator/chart.yaml?

    - kind: fixed
      description: Avoid reset of security.json if get request fails  
      links:
        - name: Github Issue
          url: https://github.com/apache/solr-operator/issues/659
        - name: Github PR
          url: https://github.com/apache/solr-operator/pull/660

I'll be good to merge this after you do that!

smoldenhauer-ish commented 3 months ago

Added the changes entry - The 'edit by maintainers' is only available to private owned forks?