Closed yash013 closed 1 year ago
Thank you very much for the PR. Can you please move the css code directly into the .scss file as @dominikriemer mentioned.
Thanks for the update! I had a look at the PR and have some minor comments:
"node_modules/datatables.net/js/jquery.dataTables.js"
in the file angular.jsondataTable
CSS class.
PipelineElementRuntimeInfoComponent
Please also merge the latest version of the dev
branch into your PR, sinc we fixed the tests there yesterday.
sure. i will do that
i was adding some css to the preview.component but it is not working .That changes worked in HelpComponent.
Did you add it to this file? ./pipeline-element-runtime-info.component.scss
The table for the priview should be located in connect/components/runtime-info/pipeline-element-runtime-info.component.html
review please
Thanks a lot, I'll have a look at it
@yash013 thanks a lot for your work so far 🙏🏼 It looks like you haven't set up the pre-commit hook for our UI. You can read here how to do this: https://github.com/apache/streampipes/blob/dev/ui/README.md
@yash013 are you still working on this PR? Otherwise, we will take over it or even close it In case you want to pick it up somewhen, you can always just reopen it
Actually I'm very busy in some other business project I will surely complete that whenever I get time. For now I'm not working on this pr hope you understand.
Sure, no problem :) Just wanted to keep up with our PRs
Hello there :wave:
We noticed that it's been some time since activity occurred on your pull request :thinking:. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed :alarm_clock:.
Please take a moment to review your pull request and make any necessary updates or changes :man_technologist:. If you need more time or have any questions, please don't hesitate to let us know :speech_balloon:.
Thank you for your contributions to our project, and we look forward to hearing back from you soon :pray:.
Hello there :wave:
Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it :raised_hands:.
Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed :computer:.
Thank you for your contributions to our project, and we hope to see you again soon!
removed these dependencies
added CSS for the DataTable in HelpComponent.