apache / streampipes

Apache StreamPipes - A self-service (Industrial) IoT toolbox to enable non-technical users to connect, analyze and explore IoT data streams.
https://streampipes.apache.org
Apache License 2.0
560 stars 172 forks source link

remove dependencies and add css for datatable. #1155

Closed yash013 closed 1 year ago

yash013 commented 1 year ago

removed these dependencies

added CSS for the DataTable in HelpComponent.

tenthe commented 1 year ago

Thank you very much for the PR. Can you please move the css code directly into the .scss file as @dominikriemer mentioned.

tenthe commented 1 year ago

Thanks for the update! I had a look at the PR and have some minor comments:

Please also merge the latest version of the dev branch into your PR, sinc we fixed the tests there yesterday.

yash013 commented 1 year ago

sure. i will do that

yash013 commented 1 year ago

i was adding some css to the preview.component but it is not working .That changes worked in HelpComponent.

tenthe commented 1 year ago

Did you add it to this file? ./pipeline-element-runtime-info.component.scss The table for the priview should be located in connect/components/runtime-info/pipeline-element-runtime-info.component.html

yash013 commented 1 year ago

review please

tenthe commented 1 year ago

Thanks a lot, I'll have a look at it

bossenti commented 1 year ago

@yash013 thanks a lot for your work so far 🙏🏼 It looks like you haven't set up the pre-commit hook for our UI. You can read here how to do this: https://github.com/apache/streampipes/blob/dev/ui/README.md

bossenti commented 1 year ago

@yash013 are you still working on this PR? Otherwise, we will take over it or even close it In case you want to pick it up somewhen, you can always just reopen it

yash013 commented 1 year ago

Actually I'm very busy in some other business project I will surely complete that whenever I get time. For now I'm not working on this pr hope you understand.

bossenti commented 1 year ago

Sure, no problem :) Just wanted to keep up with our PRs

github-actions[bot] commented 1 year ago

Hello there :wave:

We noticed that it's been some time since activity occurred on your pull request :thinking:. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed :alarm_clock:.

Please take a moment to review your pull request and make any necessary updates or changes :man_technologist:. If you need more time or have any questions, please don't hesitate to let us know :speech_balloon:.

Thank you for your contributions to our project, and we look forward to hearing back from you soon :pray:.

github-actions[bot] commented 1 year ago

Hello there :wave:

Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it :raised_hands:.

Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed :computer:.

Thank you for your contributions to our project, and we hope to see you again soon!