Streamline domain property usage

[bossenti]

Body

Although, we have a dedicated vocubalury that provides extensive definitions of several domain properties and other stuff, we have plenty of places in our code where we still have hard coded domain properties. One example can be found here.

Tasks

• [ ] collect hard-coded domain properties
• [ ] extend (and rework) vocabulayry
• [ ] replace hard-coded domain properties by vocabulary
• [ ] (extend vocabulary by common runtime names, see https://github.com/apache/streampipes/discussions/1265)

Mentoring

As this issue is marked as good first issue: one of @dominikriemer, @tenthe, or @bossenti are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help. This issue is ideal for people that are interested in getting started with StreamPipes and its SDK.

Related: https://github.com/apache/streampipes/discussions/1312

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

[zand951]

@bossenti, can I work on this. Since this is my very first open source project I just want to clarify what exactly I need to do for task 1, please bare with me :).

So, for task 1 I just need to scan through all files @ https://github.com/apache/streampipes and search for .domainProperty("foo") right?

[zand951]

Hi, could you provide me with the permission to push to a new branch please?

[zand951]

Task 1 for Streamline domain property usage #1373

Below is the location where hardcoded .domainProperty or .domainPropertyReq is found.

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-geo-jvm\src\main\java\org\apache\streampipes\processors\geo\jvm\jts\processor\buffergeometry\BufferGeomProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-geo-jvm\src\main\java\org\apache\streampipes\processors\geo\jvm\jts\processor\bufferpoint\BufferPointProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-geo-jvm\src\main\java\org\apache\streampipes\processors\geo\jvm\jts\processor\epsg\EpsgProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-geo-jvm\src\main\java\org\apache\streampipes\processors\geo\jvm\jts\processor\latlngtojtspoint\LatLngToJtsPointProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-geo-jvm\src\main\java\org\apache\streampipes\processors\geo\jvm\jts\processor\reprojection\ReprojectionProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-geo-jvm\src\main\java\org\apache\streampipes\processors\geo\jvm\jts\processor\trajectory\TrajectoryFromPointsProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-image-processing-jvm\src\main\java\org\apache\streampipes\processors\imageprocessing\jvm\processor\commons\RequiredBoxStream.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-image-processing-jvm\src\main\java\org\apache\streampipes\processors\imageprocessing\jvm\processor\genericclassification\GenericImageClassificationProcessor.java

C:\Users\Andyz\streampipes\streampipes-extensions\streampipes-processors-image-processing-jvm\src\main\java\org\apache\streampipes\processors\imageprocessing\jvm\processor\qrreader\QrCodeReaderProcessor.java

C:\Users\Andyz\streampipes\ui\src\app\dashboard\sdk\ep-requirements.ts

[flomickl]

all domainProperties in geo-jvm are linked to this discussion #1312 and would be good to be handled separately I guess

[bossenti]

@zand951 welcome to StreamPipes 🙌 Great to hear that you are interested in contributing!

Since this is my very first open source project I just want to clarify what exactly I need to do for task 1, please bare with me :).

Sure, feel free to reach out whenever you have any question 🙂

[bossenti]

could you provide me with the permission to push to a new branch please?

Unfortunately not The standard approach that is common for the vast majority of open source projects is that you create a fork of your target (in this case StreamPipes) and then create a PR from your fork to our repo Here are some more information on how to do that: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

[bossenti]

all domainProperties in geo-jvm are linked to this discussion #1312 and would be good to be handled separately I guess

@flomickl why do you think so? From my point of view the discussion is closed and we can start working on it Happy to hear your thoughts 🙂

[flomickl]

just want to mention that this is geo vocabulary and that there are more vocabularies in the backhand /mentioned in the discussion) and is part of the extent vocabulary