apache / streampipes

Apache StreamPipes - A self-service (Industrial) IoT toolbox to enable non-technical users to connect, analyze and explore IoT data streams.
https://streampipes.apache.org
Apache License 2.0
560 stars 172 forks source link

STREAMPIPES-644: Upgrade Flink version to latest 1.16 #151

Closed vesense closed 1 year ago

vesense commented 1 year ago

Purpose

Upgrade Flink version to latest 1.16

Approach

Samples

Remarks

Fixes: https://issues.apache.org/jira/browse/STREAMPIPES-644

bossenti commented 1 year ago

@vesense could you please have a look on the failed build? https://github.com/apache/streampipes/actions/runs/3522766888/jobs/5906126439#step:4:91323

vesense commented 1 year ago

@bossenti Thanks for reminding. It is successful to build in my local environment. I'll check it later.

bossenti commented 1 year ago

I'm afraid that this upgrade is not possible due to our usage of flinkspector for unit tests. Flinkspector only supports flink <= 1.14 (if I'm not mistaken) and hasn't published a release since 2019. So we probably need to look for an alternative, any ideas @tenthe @dominikriemer @vesense @RobertIndie?

tenthe commented 1 year ago

@bossenti I removed flinkspector in #1027

bossenti commented 1 year ago

@tenthe thanks, then we can update this PR and merge it I guess

bossenti commented 1 year ago

@dependabot rebase

vesense commented 1 year ago

Sorry for the delay response. Thanks @tenthe for your update https://github.com/apache/streampipes/pull/1027. I merged the https://github.com/apache/streampipes/pull/1027 into flink_1.16, the error was the same as in the before. I checked the build logs(1) and found the reason: When build streampipes-processors-aggregation-flink, maven uses the pom(2) from remote apache central repo not local. That is to say, the remote pom is not the latest version. Maybe this is a bug, @tenthe @bossenti Could you take a look?

*1: https://github.com/apache/streampipes/actions/runs/3865100468/jobs/6588382054#step:4:76696 key part:

[INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ streampipes-processors-aggregation-flink --- [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4 [INFO] Copying 3 resources from 1 bundle. Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/streampipes/streampipes-wrapper-flink/0.91.0-SNAPSHOT/streampipes-wrapper-flink-0.91.0-20230107.223648-27.pom

*2: https://repository.apache.org/snapshots/org/apache/streampipes/streampipes-wrapper-flink/0.91.0-SNAPSHOT/streampipes-wrapper-flink-0.91.0-20230107.223648-27.pom

tenthe commented 1 year ago

Hi @vesense, I tried to resolve the issues locally, but I've ran into similar problems. I suspect that the problem is with the Flink version update, some of the other dependencies related to Flink also need to be changed. We should check them one by one to see if they are still required for this Flink version or if there are alternatives that need to be used.

vesense commented 1 year ago

@tenthe Thanks for your feedback, let me have a deep check.

github-actions[bot] commented 1 year ago

Hello there :wave:

We noticed that it's been some time since activity occurred on your pull request :thinking:. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed :alarm_clock:.

Please take a moment to review your pull request and make any necessary updates or changes :man_technologist:. If you need more time or have any questions, please don't hesitate to let us know :speech_balloon:.

Thank you for your contributions to our project, and we look forward to hearing back from you soon :pray:.

github-actions[bot] commented 1 year ago

Hello there :wave:

Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it :raised_hands:.

Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed :computer:.

Thank you for your contributions to our project, and we hope to see you again soon!