apache / streampipes

Apache StreamPipes - A self-service (Industrial) IoT toolbox to enable non-technical users to connect, analyze and explore IoT data streams.
https://streampipes.apache.org
Apache License 2.0
566 stars 174 forks source link

refactor(#2095): remove update button & move permissions button #2155

Closed bossenti closed 7 months ago

bossenti commented 7 months ago

Purpose

see #2095

One pipeline element is displayed the following now: image

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

dominikriemer commented 7 months ago

@bossenti one question, how will development work without the update button? E.g., when I develop a pipeline element, I often modify configs and test them by using the update button. Will this still work with the new approach or would I need to increase the version with every change?

bossenti commented 7 months ago

We do overwrite all adapter & pipeline element descriptions when starting an extensions service right? If so, there should be no need to manually update the descriptions during development. Or am I mistaken?

tenthe commented 7 months ago

@bossenti I'm not entirely certain if this is already the case, but I agree with you on how it should be.

bossenti commented 7 months ago

I'll give it a final check before merging

bossenti commented 7 months ago

I just did a quick check: pipeline element descriptions are only updated if there is a migration in place. So for development purposes, we rely on this button or need to define a migration to update pipeline elements automatically

bossenti commented 7 months ago

Which one do we want to take?

dominikriemer commented 7 months ago

I'd prefer to keep the manual update button for now. But I like the Manage Permissions button ;-)

bossenti commented 7 months ago

Okay, fine for me Me too, but there is no space for three buttons right?