search

apache / streampipes

Apache StreamPipes - A self-service (Industrial) IoT toolbox to enable non-technical users to connect, analyze and explore IoT data streams.
https://streampipes.apache.org
Apache License 2.0
566 stars 174 forks source link

TestBooleanCounterProcessor #2545

Closed tenthe closed 2 months ago

nine03 commented 3 months ago

@tenthe Thank you for your prompt response. I have a question, is there a rule to create about branch names when creating a new branch?

tenthe commented 3 months ago

@nine03, we usually use the default branch name created by GitHub. In this case 2545-testbooleancounterprocessor.

tenthe commented 3 months ago

@nine03 just a quick note in case you have already forked the project. I have just merged the PR with JUnit 5 into the Dev branch.

nine03 commented 3 months ago

@tenthe Hi, I'm a little doubtful that I'm writing the code correctly, could you do a code review for me? Can I just post the code here or do I need to PR it? There's an error in the code to do a PR.

tenthe commented 3 months ago

Hi @nine03, I think the easiest way is to create a PR. You can also mark it as a draft. Cheers, Philipp

tenthe commented 3 months ago

@nine03 are you still working on it?

nine03 commented 3 months ago

I'm sorry. I tried to resolve this issue but I don't think I can properly solve it. The problem seems more complex and difficult than I thought. Clearly more effort was needed, but there seems to be a limit to what I can do with my abilities.

tenthe commented 3 months ago

@nine03, no worries. Thank you very much for your input. If you want to work on another issue, just get in touch.