apache / submarine

Submarine is Cloud Native Machine Learning Platform.
https://submarine.apache.org/
Apache License 2.0
697 stars 252 forks source link

SUBMARINE-1356. Add Chinese language support for workbench #1022

Closed Zang-Sz closed 1 year ago

Zang-Sz commented 1 year ago

What is this PR for?

Translate some parts to simplified Chinese.

What type of PR is it?

Improvement

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1356

How should this be tested?

NA

Screenshots (if appropriate)

screenshot

Questions:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1022 (eb1d694) into master (b830ac4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files         119      119           
  Lines        5000     5000           
=======================================
  Hits         3799     3799           
  Misses       1201     1201           
Flag Coverage Δ
python-integration 59.72% <ø> (ø)
python-unit 52.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

xunliu commented 1 year ago

hi, @Zang-Sz thank you for your contribution! Is this feature can same support English and Chinese language? through menu choice language let the workbench show different language?

cdmikechen commented 1 year ago

@xunliu Yes, it is based on issue https://issues.apache.org/jira/browse/SUBMARINE-1152