apache / submarine

Submarine is Cloud Native Machine Learning Platform.
https://submarine.apache.org/
Apache License 2.0
697 stars 252 forks source link

SUBMARINE-1355. Remove seldon graph storage initializerimage dependence #1023

Closed cdmikechen closed 1 year ago

cdmikechen commented 1 year ago

What is this PR for?

The installation of seldon-core by helm will specify the storageInitializer image and version by default, so we do not need to hard code this.

What type of PR is it?

Improvement

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1355

How should this be tested?

NA

Screenshots (if appropriate)

NA

Questions:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1023 (a68345a) into master (21bd268) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1023      +/-   ##
============================================
+ Coverage     25.48%   25.58%   +0.10%     
- Complexity     1079     1080       +1     
============================================
  Files           358      365       +7     
  Lines         29089    29134      +45     
  Branches       3479     3479              
============================================
+ Hits           7412     7455      +43     
- Misses        21461    21464       +3     
+ Partials        216      215       -1     
Flag Coverage Δ
python-integration 59.70% <ø> (+0.11%) :arrow_up:
python-unit 52.57% <ø> (+0.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/submarine/serve/seldon/SeldonGraph.java 100.00% <ø> (ø)
.../apache/submarine/serve/utils/SeldonConstants.java 0.00% <ø> (ø)
...e/submarine/serve/seldon/PredictorAnnotations.java 100.00% <100.00%> (ø)
...ine-sdk/pysubmarine/submarine/tracking/__init__.py 100.00% <0.00%> (ø)
...ne-sdk/pysubmarine/submarine/artifacts/__init__.py 100.00% <0.00%> (ø)
...marine-sdk/pysubmarine/submarine/utils/__init__.py 78.57% <0.00%> (ø)
submarine-sdk/pysubmarine/submarine/exceptions.py 100.00% <0.00%> (ø)
submarine-sdk/pysubmarine/submarine/__init__.py 100.00% <0.00%> (ø)
...marine-sdk/pysubmarine/submarine/store/__init__.py 100.00% <0.00%> (ø)
...ubmarine/submarine/ml/tensorflow/model/__init__.py 100.00% <0.00%> (ø)
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more