apache / submarine

Submarine is Cloud Native Machine Learning Platform.
https://submarine.apache.org/
Apache License 2.0
691 stars 254 forks source link

SUBMARINE-1230. Optimize submarine-operator-v3 #1026

Closed cdmikechen closed 1 year ago

cdmikechen commented 1 year ago

What is this PR for?

Optimise submarine-operator-v3 code for production deployment.

What type of PR is it?

Refactoring

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1230

How should this be tested?

submarine-operator-v3 test case in github action

Screenshots (if appropriate)

NA

Questions:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1026 (9aed80f) into master (fd692e2) will increase coverage by 0.18%. The diff coverage is 91.11%.

@@             Coverage Diff              @@
##             master    #1026      +/-   ##
============================================
+ Coverage     25.49%   25.67%   +0.18%     
- Complexity     1081     1082       +1     
============================================
  Files           358      365       +7     
  Lines         29089    29170      +81     
  Branches       3479     3479              
============================================
+ Hits           7415     7489      +74     
- Misses        21460    21466       +6     
- Partials        214      215       +1     
Flag Coverage Δ
python-integration 59.72% <75.00%> (+0.12%) :arrow_up:
python-unit 52.48% <0.00%> (+0.28%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...submarine/serve/istio/IstioVirtualServiceSpec.java 45.16% <0.00%> (ø)
...va/org/apache/submarine/server/s3/S3Constants.java 0.00% <ø> (ø)
...arine-sdk/pysubmarine/submarine/tracking/client.py 84.09% <75.00%> (-1.99%) :arrow_down:
...che/submarine/commons/utils/SubmarineConfVars.java 76.74% <100.00%> (+0.93%) :arrow_up:
...che/submarine/serve/istio/IstioVirtualService.java 46.80% <100.00%> (ø)
...g/apache/submarine/serve/utils/IstioConstants.java 83.33% <100.00%> (+83.33%) :arrow_up:
...in/java/org/apache/submarine/server/s3/Client.java 61.26% <100.00%> (+1.82%) :arrow_up:
...ver/submitter/k8s/parser/ExperimentSpecParser.java 88.88% <100.00%> (+0.88%) :arrow_up:
.../submarine/server/websocket/ConnectionManager.java 53.65% <0.00%> (-4.88%) :arrow_down:
...ine-sdk/pysubmarine/submarine/tracking/__init__.py 100.00% <0.00%> (ø)
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cdmikechen commented 1 year ago

@pingsutw Hi~ Could you have time to review this recently, please?

cdmikechen commented 1 year ago

@pingsutw I have replaced v2 with v3 in the prod. The state of the current operator-v3 run look relatively stable. And, we still need a few PRs to adapt to the new k8s version and v3 fully: