apache / submarine

Submarine is Cloud Native Machine Learning Platform.
https://submarine.apache.org/
Apache License 2.0
691 stars 254 forks source link

SUBMARINE-1366. SQLAlchemy 2.0 upgrade causes compilation failure of pysubmarine #1044

Closed cdmikechen closed 1 year ago

cdmikechen commented 1 year ago

What is this PR for?

After SQLAlchemy was upgraded to 2.0 some of the syntax was changed, which would cause syntax errors in the pysbumarine. We need to consider whether to keep the version at 1.4.x for now, or update the code and re-test it in light of the syntax issue. https://docs.sqlalchemy.org/en/20/changelog/migration_20.html Action run with exceptions: https://github.com/apache/submarine/actions/runs/4096688603/jobs/7064519374

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1366

How should this be tested?

cicd

Screenshots (if appropriate)

No

Questions:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1044 (ae66742) into master (793c8a2) will increase coverage by 16.26%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1044       +/-   ##
===========================================
+ Coverage   59.72%   75.98%   +16.26%     
===========================================
  Files         119      119               
  Lines        5000     5000               
===========================================
+ Hits         2986     3799      +813     
+ Misses       2014     1201      -813     
Flag Coverage Δ
python-integration 59.72% <ø> (ø)
python-unit 52.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
submarine-sdk/pysubmarine/submarine/cli/main.py 97.87% <0.00%> (+2.12%) :arrow_up:
...ine-sdk/pysubmarine/submarine/ml/abstract_model.py 82.35% <0.00%> (+5.88%) :arrow_up:
...-sdk/pysubmarine/submarine/artifacts/repository.py 100.00% <0.00%> (+6.66%) :arrow_up:
...rine-sdk/pysubmarine/submarine/utils/validation.py 88.40% <0.00%> (+11.59%) :arrow_up:
...ine-sdk/pysubmarine/submarine/cli/config/config.py 78.57% <0.00%> (+14.28%) :arrow_up:
...marine-sdk/pysubmarine/submarine/utils/db_utils.py 87.50% <0.00%> (+25.00%) :arrow_up:
...e-sdk/pysubmarine/submarine/cli/sandbox/command.py 100.00% <0.00%> (+25.00%) :arrow_up:
...ne-sdk/pysubmarine/submarine/cli/config/command.py 84.78% <0.00%> (+39.13%) :arrow_up:
...e-sdk/pysubmarine/submarine/utils/pytorch_utils.py 80.00% <0.00%> (+40.00%) :arrow_up:
submarine-sdk/pysubmarine/submarine/exceptions.py 100.00% <0.00%> (+45.45%) :arrow_up:
... and 37 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cdmikechen commented 1 year ago

@pingsutw Hi~ Do you have time to look at this issue? My current solution is to limit it to version 1.4.x. Maybe we can adapt it to 2.0 when we get to 0.9.0.

pingsutw commented 1 year ago

LGTM, thanks