apache / submarine

Submarine is Cloud Native Machine Learning Platform.
https://submarine.apache.org/
Apache License 2.0
691 stars 254 forks source link

SUBMARINE-1375. Fix custom resource definition requiring database secret #1059

Closed cdmikechen closed 1 year ago

cdmikechen commented 1 year ago

What is this PR for?

The operator-v3 based custom resource already supports automatic secret generation without the database password, so we don't need this config to be required.

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1375

How should this be tested?

NA

Screenshots (if appropriate)

NA

Questions:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1059 (25d5da9) into master (5987b92) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files         119      119           
  Lines        5000     5000           
=======================================
  Hits         3799     3799           
  Misses       1201     1201           
Flag Coverage Δ
python-integration 59.72% <ø> (ø)
python-unit 52.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more