Closed cdmikechen closed 1 year ago
Merging #1069 (4f5e672) into master (b830ac4) will decrease coverage by
8.73%
. The diff coverage is35.07%
.
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
- Coverage 75.98% 67.25% -8.73%
==========================================
Files 119 127 +8
Lines 5000 6139 +1139
==========================================
+ Hits 3799 4129 +330
- Misses 1201 2010 +809
Flag | Coverage Δ | |
---|---|---|
python-integration | 54.01% <35.07%> (-5.71%) |
:arrow_down: |
python-unit | 48.06% <25.59%> (-4.42%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...ine-sdk/pysubmarine/submarine/client/exceptions.py | 35.29% <7.69%> (+1.29%) |
:arrow_up: |
...ubmarine/submarine/client/api/model_version_api.py | 10.61% <10.61%> (ø) |
|
...arine/submarine/client/api/registered_model_api.py | 11.32% <11.32%> (ø) |
|
...e/submarine/client/api/experiment_templates_api.py | 15.55% <15.55%> (ø) |
|
...ne/submarine/client/api/experiment_template_api.py | 19.35% <19.35%> (ø) |
|
...-sdk/pysubmarine/submarine/client/api/serve_api.py | 19.51% <21.21%> (+3.05%) |
:arrow_up: |
...pysubmarine/submarine/client/api/experiment_api.py | 45.51% <39.00%> (-6.22%) |
:arrow_down: |
...ne/client/models/experiment_template_param_spec.py | 41.89% <41.89%> (ø) |
|
...ubmarine/client/models/experiment_template_spec.py | 42.39% <42.39%> (ø) |
|
...submarine/client/models/registered_model_entity.py | 42.39% <42.39%> (ø) |
|
... and 21 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
What is this PR for?
With the upgrade, we have fixed fixed an issue in server openapi endpoint caused by missing dependency in the meantime. At the same time, in order to ensure the validity of the openapi-generator-cli generated codes, we continue to use the old code generation method for the time being.
Also, given the range of codes involved, we haven't upgraded the openapi-generator-cli version yet. After local testing, there are significant changes with each version of 5.0 or 6.0. We'll stick with 4.3.1 for the time being until we know that major changes are needed.
What type of PR is it?
Bug Fix
Todos
gen-sdk.sh
(keep openapi-generator-cli method with keeping python2 and python3).What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1383
How should this be tested?
Git CI
Screenshots (if appropriate)
Questions: