Closed laiyousin closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 43.71%. Comparing base (
4e68894
) to head (a6a1015
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@laiyousin @xunliu
submarine.auth.default.secret
is not hard-coded and can be overridden by SUBMARINE_AUTH_DEFAULT_SECRET
in the environment variable.
Therefore, I think this PR still needs more consideration, and there are too many problems in CI that have not been solved, and it still needs the support of other fixes to merge.
Refer to the documentation https://submarine.apache.org/docs/designDocs/wip-designs/security-implementation#authentication for more authentication details.
If there is no more to deal with this PR, I will revert this recently and fix the problem in CI first.
What is this PR for?
Retrieve SUBMARINE_AUTH_SECRET from environment variable instead of using hard-coded value
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1417
How should this be tested?
Screenshots (if appropriate)
Questions: