[dashboard] [explore] Improve UI and User permissions

duynguyenhoang commented 3 years ago

There is in consistence Permissions UI between Dashboard and Explore. This issue is the next attempt after https://github.com/apache/superset/issues/13711

Expected results

If user don't have can_favstar permission
- Dashboard: Disable fav icon
- Explore page: Disable fav icon
If user don't have: can_shortner and can_share_chart
- Dashboard: Don't show "Copy chart URL", "Share chart by Email"
- Explore page: Disable "Copy chart URL", "Share chart by Email" and "Embedded Code"
If user don't have: can_sqllab
- Explore page: Remove "Run in SQL lab"
If user don't have: can_write and not the owner
- Explore page: Hide "Edit property" menu
- Explore page: Disable "Save" button

Actual results

These icons/menus are shown but when we click, error returns because of permission

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

Create a new user
Create new roles, each permission is a new role
- can_favstar
- can shortner
- can_share_chart
- can_sqllab
- can_write Chart
- can_explore (To go to explore page)
- Allow to read dashboard/slice
Assign: explore and read dashboard only to user
You still can see
- fave star icon on Dashboard page, but when you click it there is an error appear
- fave star icon on Explore page, but when you click it there is an error appear
- Share/Embed/Email icons show, but there is error when it is clicked.
- Edit Properties menu show, but user cannot change it
- SQL Lab menu appears, but user cannot go to that page.

Environment

superset version: master
python version: 3.7
node.js version: v14.15.5

Checklist

Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

duynguyenhoang commented 3 years ago

I am working with this issue right now, it takes me a while to update some unit tests.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

rusackas commented 9 months ago

Hi @duynguyenhoang - I'm trying to tidy up some old Issues and PRs. It sounds like there's a PR for this, but I'm not sure which one it is. Please advise if this is fixed and can be closed, or if there's a PR that needs to be followed up on. I was looking at your older PRs and saw you've had a lot of impact on the repo. Thanks for these contributions!

miguel-ch commented 8 months ago

@rusackas Hi there, it seems that this still not fixed, as in embedded dashboard we have the same result, not sure if there was a PR for this

rusackas commented 4 months ago

Not sure if anyone here has any intent to work on this. If not, it will be closed as stale before long.

rusackas commented 4 months ago

Hah, I didn't mean to close it right then 😅 . Reopening for now.

apache / superset