search

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
61.62k stars 13.46k forks source link

Translation process in Dockerfile does not work. #20597

Closed flowerkzj closed 1 month ago

flowerkzj commented 2 years ago

https://github.com/apache/superset/blob/8a57a71bed30a781a1d5e5b2ce42ccd08045b3e9/Dockerfile#L108

The superset only can be translated partly which only translate the codes in js but not python.

Therefore I replace it with codes below:

&& pybabel compile -d superset/translations || echo "warning: something is wrong"

Although it can solve some way, it seems not an elegant way. Hope for an official solution.

artemonsh commented 1 year ago

Sadly, I have the same issue but the requested solution does not work for me

vivek-kandhvar commented 1 year ago

Right, the flask fab babel-compile --target superset/translations command they are using is not a blocking call, and it moves on to the next step without waiting for this command to finish.

The above proposed solution works fine.

@artemonsh What's the issue?

rusackas commented 6 months ago

Is this still an issue? I presume so. I thought the backend uses the .mo files that are produced by the script, but ignored by git. I haven't validated all that... but I'm curious if this is still an issue, or if we need documentation updates, or what.

rusackas commented 1 month ago

Closing as stale, but probably also irrelevant. A lot of this has been revamped lately. Certain build processes take care of generating .mo/.json files automatically, and the .pot/.po file generation process has been smoothed out a bit. We'll continue to add CI and make this more automatic in the future.