apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
61.87k stars 13.55k forks source link

[SIP-89] Proposal for adding latin america countries to country map #21440

Closed bryanjtc closed 2 years ago

bryanjtc commented 2 years ago

Please make sure you are familiar with the SIP process documented (here)[https://github.com/apache/superset/issues/5602]. The SIP number should be the next number after the latest SIP listed here.

[SIP-89] Proposal for adding latin america countries to country map

Motivation

I'm working on a project where I need to visualise data from latin america countries, but there a lot of countries missing from the country map.

Proposed Change

I propose to add the following countries: argentina, bolivia, chile, colombia, costa rica, cuba, dominican republic, ecuador, el salvador, guatemala, haiti, honduras, nicaragua, panama, paraguay, puerto rico, saint barthelemy, saint martin and venezuela by using the guide detailed in this documentation.

New or Changed Public Interfaces

19 new countries are going to be added to the country map visualization tool

New dependencies

None

Migration Plan and Compatibility

None

Rejected Alternatives

None

betodealmeida commented 2 years ago

We probably don't need a SIP for this, I think it's just an extension of an existing feature. :)

bryanjtc commented 2 years ago

@betodealmeida Should I close this and open a new discussion? I already made a pr, I just need someone to review it.

betodealmeida commented 2 years ago

@betodealmeida Should I close this and open a new discussion? I already made a pr, I just need someone to review it.

Yeah, we can close and I can review the PR for you.

rusackas commented 2 years ago

Dropping a link to the PR here. I added @betodealmeida as a reviewer there (and a couple others for good measure).

Agreed, we can close this issue, and move on with development. Thank you for raising our awareness and for your contributions, @bryanjtc!