apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.76k stars 13.86k forks source link

[SIP-107] Proposal for Telemetry Pixel in Apache Superset #25639

Closed rusackas closed 1 year ago

rusackas commented 1 year ago

Motivation

Recently, on the Apache Superset Dev mailing list, a proposal was raised for lazy consensus to utilize Scarf telemetry in the download and installation of Apache Superset. This is already allowing the community to determine several useful new things:

The above changes have been shown at Superset Town Halls, and the documentation to configure or disable Scarf has already been added to the Superset Documentation.

Now, we’re proposing to take this telemetry to the next obvious place… Superset itself.

Proposed Change

Scarf Provides tracking pixels (essentially an HTML image tag) that you can place in your website or product to track visitors to that URL. In Superset’s case, we’ll configure the pixel as follows:

image

This results in an HTML tag that we can place into Superset… in fact, this is the pixel we’re proposing to add:

<img referrerpolicy="no-referrer-when-downgrade" src="https://static.scarf.sh/a.png?x-pxid=0d3461e1-abb1-4691-a0aa-5ed50de66af0" />

A few key details to note about the pixel:

image

New or Changed Public Interfaces

The pixel itself will be added to an innocuous yet global part of the Superset UI, i.e. either the header or the footer.

We also realize that not all organizations will approve of this pixel’s presence for any number of reasons. To support this without requiring implementations to manage code changes, we’ll add a new feature flag to config.py to enable/disable this pixel (and potentially other previously implemented Scarf features). The pixel might be called ENABLE_SUPERSET_TELEMETRY or similar. The flag will be enabled by default.

New dependencies

Only an issue of billing. Scarf has a free tier, but the depth of data retention/access is limited. The higher tiers of Scarf’s billing plans allow additional access to this historical data. Preset will work with Scarf on pricing to provide sponsorship of a higher-tier account to achieve access to this data, and make it available to all PMC members.

Migration Plan and Compatibility

This will not add any breaking changes or require migrations.

Rejected Alternatives

michael-s-molina commented 1 year ago

Closing the SIP as it was approved.