apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
63.05k stars 13.96k forks source link

`generator-superset` plugin uses deprecated and out of sync packages with the rest of Superset #27496

Open wsoeltz opened 8 months ago

wsoeltz commented 8 months ago

Bug description

The generator-superset plugin for creating custom data visualization plugins utilizes the superset-ui version of chart-controls and core, but these are now 3 years out of date with main. Are there current versions of these packages that can be swapped out in place of them? Otherwise we would need some to be made available in order to be able to continue making custom visualizations that don't fall out of sync with the rest of Superset.

https://github.com/apache/superset/blob/master/superset-frontend/packages/generator-superset/generators/plugin-chart/templates/package.erb#L32-L33

  "peerDependencies": {
    "@airbnb/config-babel": "^2.0.1",
    "@superset-ui/chart-controls": "*",
    "@superset-ui/core": "*",
    "react": "^16.13.1"
  },

How to reproduce the bug

  1. Run the generator-superset plugin
  2. View the versions of @superset-ui/chart-controls and @superset-ui/core that are installed
  3. Both are derived from the archived superset-ui repo

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

musfir-tariq commented 2 months ago

Hi @wsoeltz. Were you able to find a fix for this issue?

wsoeltz commented 2 months ago

Hi @wsoeltz. Were you able to find a fix for this issue?

No, we ended up having to fork Superset and build our chart package inside the monorepo