Export to Excel is not working for legacy charts

dkrat7 commented 6 months ago

Bug description

"Export to Excel" function does not create xlsx file, instead JSON data are shown in browser. Tested in version 4.0.0 (docker image).

(however, it works for CSV export)

How to reproduce the bug

Go to example dashboard with legacy chart,
Select Export to Excel on one of legacy charts,
Chart data should be exported to xlsx file.

Screenshots/recordings

Screencast 2024-03-15 18:03:46.webm

Superset version

4.0.0

Python version

3.9

Node version

16

Browser

Firefox

Additional context

No response

Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

jpmonette commented 5 months ago

Same thing, I do get the JSON object, but not on all charts.

I do get it on the bar and line chart for example, but not on pie charts or KPIs.

rusackas commented 5 months ago

Hmmm... that's the old explore_json endpoint, used by legacy charts, as opposed to the v1/chart/data endpoint, which is newer. I wonder the Excel export is broken for all the legacy charts, then.

dkrat7 commented 5 months ago

I tested the excel export function with other legacy charts and it is not working. I updated this issue from deck.gl to all legacy charts.

apache / superset