apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.06k stars 13.61k forks source link

Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar #28318

Open andrekef opened 5 months ago

andrekef commented 5 months ago

Bug description

When utilizing the search bar functionality within a table in GitHub, the total calculation feature fails to adjust accordingly. This means that when searching for specific values within the table, the total calculation displayed does not reflect the filtered results, leading to inaccuracies in data analysis and reporting.

How to reproduce the bug

  1. Go to a Table that has a Search bar and Show Totals enabled
  2. Populate the table
  3. Perform a search using the search bar for specific values within the table. I used a ticketID
  4. Observe that the table adjusts to show only the rows matching the search criteria.
  5. Check the "Show Total" calculation displayed at the bottom of the numerical column.
  6. Note that the total calculation does not adjust to reflect the filtered results; it continues to display the total for all values, including those not visible due to the search filter.

Screenshots/recordings

Screenshot 2024-05-02 at 9 43 04 AM

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

When I conduct cross filtering

Screenshot 2024-05-02 at 9 45 29 AM

, the Show Totals works

Checklist

rusackas commented 5 months ago

Ahh yes.. the crossfilter actually changes the data being fed to the table, so the total is calculated. The filter IN the table doesn't appear to recalculate on the fly. I'm sure it could if it had all the data, but if server pagination comes into play, that gets quite complicated.

Not sure if @justinpark 's planned migration to AG Grid would solve this.