Export to pdf and Download as image actions not translated in french

martin-raymond commented 5 months ago

Bug description

On top of the dashboard, in the drop down menu, in french, the action to 'Export to pdf' and 'Download as image' are not translated.

How to reproduce the bug

Have your superset current languages in french
Open the drop down menu top right on your dashboard
Expand the download section

Screenshots/recordings

No response

Superset version

3.1.3

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

dosubot[bot] commented 5 months ago

To address the issue where 'Export to PDF' and 'Download as Image' options are not translated into French in Superset version 3.1.3, you should first verify if the translation strings for these actions exist in the French localization file (superset/translations/fr/LC_MESSAGES/messages.po). If they're missing, you can add them as follows:

msgid "Export to PDF"
msgstr "Exporter en PDF"

msgid "Download as Image"
msgstr "Télécharger comme image"

After adding these strings, compile the translation files with:

flask fab babel-compile --target superset/translations

Then, restart Superset to apply the changes. This process ensures that Superset uses the updated translations, making the 'Export to PDF' and 'Download as Image' options appear in French.

For more detailed guidance on managing translations in Superset, including how dynamic content is translated, refer to the Superset repository and specifically the French localization file here. This file is crucial for the localization process, enabling Superset to display UI elements in French based on the user's locale settings.

#### Details

**Sources** - [superset/translations/fr/LC_MESSAGES/messages.po](https://github.com/apache/superset/blob/master/superset/translations/fr/LC_MESSAGES/messages.po) - [superset-frontend/packages/superset-ui-core/src/translation/types/index.ts](https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/translation/types/index.ts) - [superset/translations/requirements.txt](https://github.com/apache/superset/blob/master/superset/translations/requirements.txt) - [superset-frontend/packages/superset-ui-core/src/translation/index.ts](https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/translation/index.ts) - [superset/translations/tr/LC_MESSAGES/messages.po](https://github.com/apache/superset/blob/master/superset/translations/tr/LC_MESSAGES/messages.po) - [superset/translations/messages.pot](https://github.com/apache/superset/blob/master/superset/translations/messages.pot) - [superset-frontend/src/setup/setupApp.ts](https://github.com/apache/superset/blob/master/superset-frontend/src/setup/setupApp.ts)
**About Dosu** This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

rusackas commented 4 months ago

I'll leave this open for a bit, but we don't consider missing translations as bugs. If we did, we'd have a LOT of bugs. We encourage you to open PRs to add/fix as many translations as you'd like!

apache / superset