Ephemeral instances no longer have any example data

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform

https://superset.apache.org/

Apache License 2.0

63.08k stars 13.97k forks source link

Ephemeral instances no longer have any example data #29694

Closed sadpandajoe closed 3 months ago

sadpandajoe commented 4 months ago

Bug description

When you spin up an ephemeral instance in a PR, example data such as dashboard, charts, etc. no longer exist.

How to reproduce the bug

Go to a PR
Spin up an ephemeral
Log into the ephemeral
Go to the dashboard list

Notice that the dashboard list is empty where we used to have example dashboards.

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

Browser

Chrome

Additional context

No response

Checklist

[ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
[ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

dosubot[bot] commented 4 months ago

Hey @sadpandajoe! I'm here to assist you with any bugs, questions, or contributions while we wait for a human maintainer. Let's tackle this together!

The example data such as dashboards and charts no longer exist when spinning up an ephemeral instance in a PR because the provided workflow configuration does not include any steps to load or initialize example data. To include example data, you need to add steps in the workflow to load the example data after the environment is spun up. You can use scripts like misc_dashboard.py to load example dashboards and charts, or leverage the ImportAssetsCommand from the superset.commands.importers.v1.assets module to import predefined configurations for databases, datasets, charts, and dashboards ^[1]^[2]^[3].

To continue talking to Dosu, mention @dosu.

sadpandajoe commented 4 months ago

@michael-s-molina we tracked it down to your PR: https://github.com/apache/superset/pull/28789 that was causing this. Wondering if you have time to take a look at this?

michael-s-molina commented 4 months ago

@sadpandajoe @eschutho @rusackas I executed the load examples command many times in my dev environment so I believe if might be something with the ephemeral environment. Do you have any additional information about the error? Any logs?

I'm really busy for the next days so feel free to revert the PR if needed.

rusackas commented 4 months ago

This might be a clue for anyone looking into this: https://github.com/apache/superset/issues/27633

sadpandajoe commented 4 months ago

@michael-s-molina I've created this PR to revert in case if you can't get to this before 4.1 is ready: https://github.com/apache/superset/pull/29766. Will hold off from merging for now.