On the chart editing screen, the icon of dataset should be similar to those used on the “Dataset” screen.

xavier-GitHub76 commented 1 month ago

Hello,

Physical and virtual data sets do not have the same pictogram.

On the chart editing screen, the icon should be similar to those used on the “Dataset” screen.

kasiazjc commented 1 month ago

Hello,

Physical and virtual data sets do not have the same pictogram.

On the chart editing screen, the icon should be similar to those used on the “Dataset” screen.

Hi, thanks for raising this! I definitely agree, do you think it's something you would be able to change? 🙏

xavier-GitHub76 commented 3 weeks ago

I can try but I'm a novice. Could you help me to identify files to changed ?

After, I will try to see how to add the control on the kind of dataset and apply the good SVG :

Physical dataset :

<svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" fill="currentColor" aria-hidden="true" focusable="false" class="" viewBox="0 0 24 24">
    <path fill="currentColor" fill-rule="evenodd" d="M21 2.5H3a1 1 0 0 0-1 1v18a1 1 0 0 0 1 1h18a1 1 0 0 0 1-1v-18a1 1 0 0 0-1-1m-13 18H4v-4h4zm0-6H4v-4h4zm0-6H4v-4h4zm6 12h-4v-4h4zm0-6h-4v-4h4zm0-6h-4v-4h4zm6 12h-4v-4h4zm0-6h-4v-4h4zm0-6h-4v-4h4z" clip-rule="evenodd"></path>
</svg>

Virtual Dataset :

<svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" fill="currentColor" aria-hidden="true" focusable="false" class="" viewBox="0 0 24 24"> 
    <path fill="#136478" d="M4 4.5h16v16H4z"></path>
    <path fill="#A5DBE9" fill-rule="evenodd" d="M21 2.5H3a1 1 0 0 0-1 1v18a1 1 0 0 0 1 1h18a1 1 0 0 0 1-1v-18a1 1 0 0 0-1-1m-13 18H4v-4h4zm0-6H4v-4h4zm0-6H4v-4h4zm6 12h-4v-4h4zm0-6h-4v-4h4zm0-6h-4v-4h4zm6 12h-4v-4h4zm0-6h-4v-4h4zm0-6h-4v-4h4z" clip-rule="evenodd"></path>
</svg>

apache / superset

On the chart editing screen, the icon of dataset should be similar to those used on the “Dataset” screen. #29710