dosubot[bot]
commented
1 month ago Hey @jinmengcheng! I'm here to help you with any bugs, questions, or contributions you may have regarding the Superset upgrade. Let's work together to solve this issue!
To resolve the issue of the user_favorite_tag table not being created when upgrading Apache Superset from version 3.0.1 to 4.0.2 using Docker on MacOS, you need to ensure that the Alembic migrations are applied correctly. Here are the steps to follow:
-
Ensure the migration script is in place: Verify that the migration script
2023-07-12_20-34_e0f6f91c2055_create_user_favorite_table.pyis located in the correct directory within your Superset project, typically undersuperset/migrations/versions/. -
Shut down running containers: First, make sure to shut down the running containers in Docker Compose:
docker compose down -
Update the Superset repository: Update the folder that mirrors the
supersetrepo through git:git pull origin master -
Restart the containers: Restart the containers and any changed Docker images will be automatically pulled down:
docker compose up -
Run the migration: Execute the Alembic upgrade command to apply the migrations. You can do this by running the following command inside your Docker container:
docker exec -it <container_name> superset db upgradeReplace
<container_name>with the name of your Superset Docker container. -
Initialize Superset: Run the following command to initialize Superset:
docker exec -it <container_name> superset init -
Verify the table creation: After running the migration, check your database to ensure that the
user_favorite_tagtable has been created.
The upgrade function in the migration script should create the user_favorite_tag table as follows:
def upgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.create_table(
"user_favorite_tag",
sa.Column("user_id", sa.Integer(), nullable=False),
sa.Column("tag_id", sa.Integer(), nullable=False),
sa.ForeignKeyConstraint(
["tag_id"],
["tag.id"],
),
sa.ForeignKeyConstraint(
["user_id"],
["ab_user.id"],
),
)
# ### end Alembic commands ###Additionally, ensure that the user_favorite_tag table is correctly defined in your models. According to the superset/tags/models.py file, the table should be defined as follows:
user_favorite_tag_table = Table(
"user_favorite_tag",
Model.metadata, # pylint: disable=no-member
Column("user_id", Integer, ForeignKey("ab_user.id")),
Column("tag_id", Integer, ForeignKey("tag.id")),
)If the table is still not created, ensure that there are no errors in the migration script and that the database connection is properly configured [1][2][3].
To continue talking to Dosu, mention @dosu.
jinmengcheng
ruifpedro
rusackas
mistercrunch
Bug description
Hi Superset developers: I am trying to upgrade superset 3.0.1 to 4.0.2, main features looks good so far, but there is a small problem when I am trying to use Tag system, please check the screenshot as attached, favorite tag feature seems not available, after check log, error trace shows "user_favorite_tag" table not exists, it seems "superset db upgrade" not patched revision "e0f6f91c2055" to DB, but the "superset db history" shows "e0f6f91c2055" has been applied, would you please take a look?
ENV: Docker MacOS/Safari superset version: 3.0.1 -> 4.0.2
[SQL: SELECT user_favorite_tag.tag_id AS user_favorite_tag_tag_id FROM user_favorite_tag WHERE user_favorite_tag.tag_id IN (%(tag_id_1_1)s, %(tag_id_1_2)s, %(tag_id_1_3)s, %(tag_id_1_4)s, %(tag_id_1_5)s) AND user_favorite_tag.user_id = %(user_id_1)s]
How to reproduce the bug
Screenshots/recordings
No response
Superset version
4.0.2
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist