search

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
61.99k stars 13.59k forks source link

chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG #30284

Open nsivarajan opened 1 week ago

nsivarajan commented 1 week ago

SUMMARY

This PR follows up on https://github.com/apache/superset/pull/29912 and removes the deprecated GLOBAL_ASYNC_QUERIES_REDIS_CONFIG configuration in favor of the new GLOBAL_ASYNC_QUERIES_CACHE_BACKEND configuration. It is intended to be merged into version 5.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (76d897e) to head (720a02f). Report is 738 commits behind head on master.

Files with missing lines Patch % Lines
superset/async_events/async_query_manager.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30284 +/- ## =========================================== + Coverage 60.48% 83.75% +23.26% =========================================== Files 1931 534 -1397 Lines 76236 38544 -37692 Branches 8568 0 -8568 =========================================== - Hits 46114 32282 -13832 + Misses 28017 6262 -21755 + Partials 2105 0 -2105 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.94% <75.00%> (-0.23%)` | :arrow_down: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [mysql](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.74% <75.00%> (?)` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.81% <75.00%> (?)` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.44% <75.00%> (-0.37%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.75% <75.00%> (+20.26%)` | :arrow_up: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.26% <75.00%> (?)` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.51% <75.00%> (+2.88%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rusackas commented 1 week ago

I think @villebro has the most context here, so I'll request his review, and re-start our flaky E2E test while I'm at it.