Closed birkskyum closed 1 month ago
/testenv up
@birkskyum to test/review these PRs, we typically need to check the plugin. There are a few ways to do this: 1) starting an ephemeral env here so anyone can test it (needs to be done by a committer) 2) pulling the change locally and running Superset (better in this case so we can add a mapbox key) 3) pulling the change locally and running Storybook
I'll start with #1 here before I approve. @mistercrunch was your review a code review, or did you test/validate the upgrade?
I only reviewed the 3 lines, seemed benign, didn't test locally
Tested, works great! Thanks, @birkskyum!
No idea why ephemeral environments aren't working again. Any ideas, @mistercrunch? Did those move to supersetbot or something?
SUMMARY
Part of:
30307
Modernizing the legacy-plugin-chart-map-box reduces the diff towards MapLibre.
This PR updates Supercluster from v4 to v8, which improves performance and memory use for of this plugin.
TESTING INSTRUCTIONS
@rusackas , how does the review process generally work for these plugins? Are there some specific people who cover this part of the code?