apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.8k stars 13.87k forks source link

chore(legacy-plugin-chart-map-box): bump supercluster to v8 #30305

Closed birkskyum closed 1 month ago

birkskyum commented 2 months ago

SUMMARY

Part of:

Modernizing the legacy-plugin-chart-map-box reduces the diff towards MapLibre.

This PR updates Supercluster from v4 to v8, which improves performance and memory use for of this plugin.

TESTING INSTRUCTIONS

Screenshot 2024-09-17 at 11 15 56

@rusackas , how does the review process generally work for these plugins? Are there some specific people who cover this part of the code?

rusackas commented 1 month ago

/testenv up

rusackas commented 1 month ago

@birkskyum to test/review these PRs, we typically need to check the plugin. There are a few ways to do this: 1) starting an ephemeral env here so anyone can test it (needs to be done by a committer) 2) pulling the change locally and running Superset (better in this case so we can add a mapbox key) 3) pulling the change locally and running Storybook

I'll start with #1 here before I approve. @mistercrunch was your review a code review, or did you test/validate the upgrade?

mistercrunch commented 1 month ago

I only reviewed the 3 lines, seemed benign, didn't test locally

rusackas commented 1 month ago

Tested, works great! Thanks, @birkskyum!

rusackas commented 1 month ago

No idea why ephemeral environments aren't working again. Any ideas, @mistercrunch? Did those move to supersetbot or something?