apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.8k stars 13.87k forks source link

feat: reading language from url + resource type check fix #30318

Open nyohasstium opened 1 month ago

nyohasstium commented 1 month ago

SUMMARY

fix(embedded dashboard): resource type was not checked appropriately against enum. feat(UI): added currency and language to URL_PARAMS feat(API): using language based on query parameter if found and defaulting to session value

TESTING INSTRUCTIONS

rusackas commented 1 month ago

Hi @nyohasstium - just curious your thoughts on the review comments. Let us know if we can help you carry this effort forward.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.88%. Comparing base (76d897e) to head (41989a6). Report is 812 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30318 +/- ## =========================================== + Coverage 60.48% 83.88% +23.40% =========================================== Files 1931 533 -1398 Lines 76236 38495 -37741 Branches 8568 0 -8568 =========================================== - Hits 46114 32293 -13821 + Misses 28017 6202 -21815 + Partials 2105 0 -2105 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.01% <100.00%> (-0.15%)` | :arrow_down: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [mysql](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.84% <100.00%> (?)` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.93% <100.00%> (?)` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.52% <100.00%> (-0.29%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.88% <100.00%> (+20.40%)` | :arrow_up: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.38% <100.00%> (?)` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/30318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.60% <25.00%> (+2.97%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.