legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region

SBIN2010 commented 1 month ago

Bug description

Karelia is not displayed correctly on the map of Russia. It should be located separately, and not as part of Murmansk

How to reproduce the bug

Open legacy-plugin-chart-country-map map of Russia

Screenshots/recordings

To after

Superset version

4.0.2

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

dosubot[bot] commented 1 month ago

Hello @SBIN2010! I'm here to assist you with any bugs, questions, or contributions. Let's work together to resolve the issue you're facing.

To fix the issue where Karelia is incorrectly displayed as part of the Murmansk region on the legacy-plugin-chart-country-map for Russia in Superset version 4.0.2, you need to ensure that the GeoJSON data for Karelia is correctly defined and not overlapping with the Murmansk region.

Here is the correct GeoJSON data for Karelia:

{
  "type": "Feature",
  "properties": { "ISO": "RU-KR", "NAME_1": "Karelia" },
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [35.8583984375, 65.077929687500003],
        [35.827343750000011, 65.036474609375006],
        [35.84228515625, 65.00146484375],
        [35.778710937500023, 64.976660156250006],
        [35.680078125000023, 65.0576171875],
        [35.621386718750017, 65.058789062499997],
        [35.55859375, 65.093603515625006],
        [35.52890625, 65.151074218749997],
        [35.585742187500017, 65.167089843750006],
        [35.608691406250017, 65.157128906249994],
        [35.729101562500006, 65.197558593750003],
        [35.816113281250011, 65.182080078124997],
        [35.848437500000017, 65.142675781250006],
        [35.8583984375, 65.077929687500003]
      ]
    ]
  }
}

Ensure that this data is correctly placed in the russia.geojson file and that there are no overlapping coordinates with the Murmansk region. If the Murmansk region's data is incorrect, you will need to correct it similarly by ensuring its coordinates do not overlap with Karelia ^[1].

To continue talking to Dosu, mention @dosu.

SBIN2010 commented 1 month ago

@dosu. This is a little different from what I'm talking about. Here's an example of how it should be

rusackas commented 1 month ago

If you're able/willing to open a PR to correct this, the right way to do so would be to make a correction in the Jypyter Notebook (the repo's one .ipynb file) and have THAT render out the geoJSON. Otherwise, any GeoJSON overrides will eventually be overwritten in the future. Also, the files we get are generated from NaturalEarth data... you may want to ping them on their repo about correcting it at the root. We're downstream, and just patch things with overrides as much as we're able to.

dosubot[bot] commented 1 month ago

To correctly display Karelia separately from the Murmansk region on the legacy-plugin-chart-country-map for Russia in Superset version 4.0.2, you need to ensure that the GeoJSON data for both Karelia and the Murmansk region are correctly defined and distinct in the russia.geojson file.

Here is the correct GeoJSON data for Karelia:

{
  "type": "Feature",
  "properties": { "ISO": "RU-KR", "NAME_1": "Karelia" },
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [35.8583984375, 65.077929687500003],
        [35.827343750000011, 65.036474609375006],
        [35.84228515625, 65.00146484375],
        [35.778710937500023, 64.976660156250006],
        [35.680078125000023, 65.0576171875],
        [35.621386718750017, 65.058789062499997],
        [35.55859375, 65.093603515625006],
        [35.52890625, 65.151074218749997],
        [35.585742187500017, 65.167089843750006],
        [35.608691406250017, 65.157128906249994],
        [35.729101562500006, 65.197558593750003],
        [35.816113281250011, 65.182080078124997],
        [35.848437500000017, 65.142675781250006],
        [35.8583984375, 65.077929687500003]
      ]
    ]
  }
}

And here is an example of how you might define the Murmansk region:

{
  "type": "Feature",
  "properties": { "ISO": "RU-MUR", "NAME_1": "Murmansk" },
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [32.0, 69.0],
        [33.0, 69.0],
        [33.0, 68.0],
        [32.0, 68.0],
        [32.0, 69.0]
      ]
    ]
  }
}

Ensure both regions are included in the russia.geojson file. This will ensure that Karelia and the Murmansk region are displayed separately on the map ^[1].

To continue talking to Dosu, mention @dosu.

apache / superset