fix:(legacy-plugin-chart-country-map)Fix the territories of Karelia and Murmansk(#30326) - Githubissues

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform

https://superset.apache.org/

Apache License 2.0

61.99k stars 13.59k forks source link

fix:(legacy-plugin-chart-country-map)Fix the territories of Karelia and Murmansk(#30326) #30328

Closed SBIN2010 closed 2 days ago

SBIN2010 commented 1 week ago

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
[ ] Introduces new feature or API
[ ] Removes existing feature or API

SBIN2010 commented 2 days ago

I don't think it's a good idea to add such changes to the Jupyter notebook. Since I found this flaw in the NaturalEarth database, and have already created an issue to fix it. (https://github.com/nvkelso/natural-earth-vector/issues/929) Therefore, when the corrections appear in NaturalEarth, then it will be correct in Superset.