Table chart was removing the extras from the summary query, assuming they were only used for time grains. This PR fixes that and put the extras back in the queryObject sent as payload, now, only excluding time_grain_sqla if no temporal column is included in your chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Excluding extras from summary query and only adding it if no time comparison was used
Now: Sending extras in the total query regardless you're using time comparison
No temporal Column
With temporal Column
TESTING INSTRUCTIONS
Create a Table Chart
Use no temporal column and a custom SQL filter
Mark the Show summary checkbox
The queries sent as payload must include the where in extras for both queries and not include a time_grain_sqla
Now add a temporal column to your chart and run the query again
The time_grain_sqla must be present in the extras alongside with the where clause
SUMMARY
Table
chart was removing theextras
from the summary query, assuming they were only used for time grains. This PR fixes that and put the extras back in the queryObject sent as payload, now, only excludingtime_grain_sqla
if no temporal column is included in your chart.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Excluding extras from summary query and only adding it if no time comparison was used
Now: Sending extras in the total query regardless you're using time comparison No temporal Column
With temporal Column
TESTING INSTRUCTIONS
Table
ChartShow summary
checkboxwhere
in extras for both queries and not include atime_grain_sqla
time_grain_sqla
must be present in the extras alongside with thewhere
clauseADDITIONAL INFORMATION