fix(CI): increase node JS heap size

rusackas commented 1 week ago

SUMMARY

This is a bit of a shot in the dark, but I saw that some Jest tests were failing due to Javascript running out of heap memory (see screenshot). My conjecture is that the Native Filter tests we're struggling with are the same issue we're running into here.

So... let's throw a dart at the problem. Apparently, the default size is 1.5GB, so let's go to 4! GPT thinks this'll work for both jest, and the chrome/chromium browser we use in E2E tests, so here goes nothing! Apparently the small GH action runners have 7GB ram, so this seems reasonable-ish.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

If CI passes, we should be good.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
[ ] Introduces new feature or API
[ ] Removes existing feature or API

villebro commented 1 week ago

No PR talking about dialing something up should go without a reference to Spinal Tap..

rusackas commented 1 week ago

No PR talking about dialing something up should go without a reference to Spinal Tap..

LOL, I'm literally trying to get a tattoo of that knob. Awaiting response from two artists.

villebro commented 1 week ago

LOL, I'm literally trying to get a tattoo of that knob. Awaiting response from two artists.

After that I feel you should be granted permission to self-approve any PR making these types of changes 🎛️

rusackas commented 1 week ago

Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does...

villebro commented 1 week ago

Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does...

That's one of the less frequently flaking tests, and is probably unaffected by extra memory

rusackas commented 1 week ago

I'm actually optimistic about the quicker part... this should use less swap, at least.

apache / superset