apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
61.99k stars 13.59k forks source link

fix(explore): Missing markarea component broke annotations in echarts #30348

Closed kgabryje closed 1 week ago

kgabryje commented 1 week ago

SUMMARY

Recent Echarts bundle size optimization PR didn't register MarkLineComponent and MarkAreaComponent from echarts/components package, which broke annotations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

  1. Create an annotation layer
    • date 2000-01-01 -> 2002-01-01
  2. Save
  3. Create an Echarts line chart with wb_health_population dataset
  4. Use year as x-axis, sum__SP_POP_TOTL as metric
  5. Add the annotation
    • Show labe = checked
    • annotation layer type = interval
    • annotation source = Superset annotation
    • annotation layer = your annotation layer
    • hit ok
  6. click update chart
  7. Verify that the annotation is visible
  8. Do the same for annotation layer type = Event

ADDITIONAL INFORMATION

kgabryje commented 1 week ago

/testenv up

github-actions[bot] commented 1 week ago

@kgabryje Ephemeral environment spinning up at http://52.25.177.79:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions[bot] commented 1 week ago

Ephemeral environment shutdown and build artifacts deleted.