apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.8k stars 13.87k forks source link

chore(fe): uplift FE packages to latest version #30357

Closed hainenber closed 1 month ago

hainenber commented 1 month ago

chore(fe): uplift FE packages to latest version

SUMMARY

Changes:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

hainenber commented 1 month ago
  • Uplift fetch-mock to v11 + corresponding refactoring for superset-ui-core.
  • Uplift following packages to latest version.
    • @testing-library/react-hooks
    • @testing-library/jest-dom
    • webpack-cli

These are dev dependencies and any breakages are detected in frontend-build CI. Current check is green so these uplift are safe

Move @types/* packages in superset-ui-core to devDependencies.

Moving of @types/* package that are actual dependency will generate linting issue. This can be illustrated by moving @types/json-bigint into devDependencies in superset-ui-core. Current build is green so the uplift is safe.

image

Only risk is with npm audit fix as it might bump packages not respecting semver. However, from my inspection, they're mostly version bumps of dev dependencies (this is at 95% confidence interval :D)

rusackas commented 1 month ago

Sorry for letting this sit too long. Looks like it needs needed a rebase, but barring that, it's fine with me if it passes CI!