We're currently not logging flask warnings to the logger as part of the "catch all" @safe or @handle_api_exception decorators. I think @handle_api_exception does a more thorough job of catching different errors and handling, logging, raising, etc. We're applying @handle_api_exception on most base restapi functions, but using @safe on the adhoc apis. Maybe we can look at combining these and only having one decorator. I also removed the exception handling in the api because they will be caught and handled in the decorator.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided
SUMMARY
We're currently not logging flask warnings to the logger as part of the "catch all" @safe or @handle_api_exception decorators. I think @handle_api_exception does a more thorough job of catching different errors and handling, logging, raising, etc. We're applying @handle_api_exception on most base restapi functions, but using @safe on the adhoc apis. Maybe we can look at combining these and only having one decorator. I also removed the exception handling in the api because they will be caught and handled in the decorator.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION