fix(ECharts): Revert ECharts version bump

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform

https://superset.apache.org/

Apache License 2.0

61.98k stars 13.59k forks source link

fix(ECharts): Revert ECharts version bump #30388

Closed geido closed 2 days ago

geido commented 2 days ago

SUMMARY

PR https://github.com/apache/superset/pull/29963 has bumped ECharts to version 5.5.1. However, we have seen several issues with running the frontend. This PR reverts ECharts to previous version 5.4.1.

BEFORE

TESTING INSTRUCTIONS

Open a Dashboard with ECharts
ECharts should load

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
[ ] Introduces new feature or API
[ ] Removes existing feature or API

kgabryje commented 2 days ago

I guess that's our culprit... (from changelog)

michael-s-molina commented 2 days ago

@rusackas @hainenber Maybe we should require PR authors to include the CHANGELOG in the PR description when bumping minor/major versions?

michael-s-molina commented 2 days ago

By the way, it seems ECharts does not respect semver as this was a minor bump with a breaking change given @kgabryje's screenshot. This will require additional attention when bumping ECharts.

@villebro for awareness.

hainenber commented 2 days ago

Apologies all for the mess I made and thanks for fixing the horror @geido 👏

@michael-s-molina I will be more dilligent in bumping minor versions in the future. Semver is only a convention, after all 🤒

michael-s-molina commented 2 days ago

Apologies all for the mess I made and thanks for fixing the horror @geido 👏

@michael-s-molina I will be more dilligent in bumping minor versions in the future. Semver is only a convention, after all 🤒

No problem at all @hainenber. We really appreciate all the amazing contributions you have made to Superset. My comment is just to keep improving the process 😉

hainenber commented 2 days ago

Thanks. It's this amazing Superset community that aspire me to improve the platform further! 🙌

I think we might want to have some sort of Echarts integration test to keep ourselves less paranoid when it comes to bumping its version.