Open michael-s-molina opened 21 hours ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.77%. Comparing base (
76d897e
) to head (355df1c
). Report is 786 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Does it make sense to raise a warning that non-numeric data has been excluded when records are coerced to NaN?
Good point @fisjac. I changed the logic to let users handle non-numeric values as they might want to fix their datasets or add filters to remove these values.
SUMMARY
Fixes https://github.com/apache/superset/issues/30301 by making the Histogram chart more resilient when handling non-numeric columns or numeric columns with non-numeric values.
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION